This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Revert "Include erb files for analysis, following Flay" #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABaldwinHunter
force-pushed
the
abh-revert-erb-files
branch
from
caf38e4 to
705646f
Compare
This reverts commit 620f2dd in response to seeing duplication issues found on intuitively small snippets of erb templates. Roll back to consider configuration/threshold options and tuning.
ABaldwinHunter
force-pushed
the
abh-revert-erb-files
branch
from
705646f to
ea8a3f0
Compare
|
@noahd1 updated commit message: |
|
LGTM |
|
👍 |
ABaldwinHunter
pushed a commit
that referenced
this pull request
Jan 29, 2016
Revert "Include erb files for analysis, following Flay"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 620f2dd.
Roll back functionality in favor of allowing for additional
consideration about configuration/threshold options and tuning
impact on analysis.
@codeclimate/review @noahd1